Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pk5 fix tests prerelease #6688

Closed
wants to merge 231 commits into from
Closed

Conversation

sunnycarter
Copy link
Contributor

Copy of this PR: jddarby#67

patrykkulik-microsoft and others added 25 commits July 26, 2023 15:50
* Somewhat working example

* Cleanups

* Update recording

* fix minor linting error
* Modify changelog and rename tests

* Delete recording file
* Modify changelog and rename tests

* Delete recording file

* Fix the credentials issue in the integration tests

* Update CHANGELOG

* Markups

* Fix typo

* Minor markups

* Make cleaning up resources more robust and remove the VHD external reference

* Markups
* Fix bicep render on Windows

* Fixes for Windows

* python-static-checks ran
For running in environments without docker, such as CI pipelines.
This affects uploading Helm charts for CNFs - the ACR login now fetches
an access token, which is used to login to the Helm registry and upload
the chart.
* pre-release version of release markups

* markups and fixes
* Fix integration tests

* Update src/aosm/development.md

Co-authored-by: Cyclam <[email protected]>

* Update src/aosm/azext_aosm/tests/latest/test_aosm_cnf_publish_and_delete.py

Co-authored-by: Cyclam <[email protected]>

* Update src/aosm/azext_aosm/tests/latest/test_aosm_cnf_publish_and_delete.py

Co-authored-by: Cyclam <[email protected]>

* Markup changes

---------

Co-authored-by: Cyclam <[email protected]>
Co-authored-by: Sunny Carter <[email protected]>
@azure-client-tools-bot-prd
Copy link

Validation for Breaking Change Starting...

Thanks for your contribution!

@azure-client-tools-bot-prd
Copy link

Hi @sunnycarter,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Aug 24, 2023

Thank you for your contribution! We will review the pull request and get back to you soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants